Skip to content

Fix #80 #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2018
Merged

Fix #80 #82

merged 2 commits into from
May 22, 2018

Conversation

delirious-lettuce
Copy link
Contributor

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

While I was fixing the above issue, I also cleaned up a couple other things in the file.

  • Remove unused imports
  • Remove excess whitespace
  • Add whitespace around = operator

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@delirious-lettuce
* Fix sendgrid#80 (remove a blank line above test definition, fix lin…
d0c14a3 
…e length)

* Remove unused imports
* Remove excess whitespace
* Add whitespace around `=` operator
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jan 8, 2018
@thinkingserious
Copy link
Contributor

Thanks @delirious-lettuce! I've added this to our backlog for review.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jan 12, 2018
@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Feb 27, 2018
@thinkingserious thinkingserious merged commit 969b515 into sendgrid:master May 22, 2018
@thinkingserious
Copy link
Contributor

Hello @delirious-lettuce,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@delirious-lettuce
Copy link
Contributor Author

@thinkingserious ,

No problem!

@delirious-lettuce delirious-lettuce deleted the fix_80 branch May 22, 2018 21:12
@codecov
Copy link

codecov bot commented May 22, 2018

Codecov Report

Merging #82 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   92.28%   92.22%   -0.06%     
==========================================
  Files           6        6              
  Lines         298      296       -2     
==========================================
- Hits          275      273       -2     
  Misses         23       23
Impacted Files Coverage Δ
tests/test_unit.py 99.21% <100%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecb28e5...4ae4d97. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Two Pep8 issues reported in TravisCI
2 participants
@delirious-lettuce @thinkingserious